feat: Enable sprig template function library to webhook template render #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Thanks for contributing to NTH! I've glanced at the changes in the PR and everything looks pretty good, but please allow us some extra time to review since it does bring in several dependencies that we'll need to look into (we'll also be out until June 2nd for a US Holiday, Memorial Day). Thanks for your patience! |
|
LGTM! Thanks for the PR once again |
|
I'll merge this PR at the same time the license PR is merged: #446 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR we enable sprig functions template library to the Webhook Template.
This functionality is really helpful to our case as we are using the same configuration to multiple clusters with different versions and the node labels are not always the same.
i.e.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.