[ec2metadata] Switch IMDSv2 token warning message to debug #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If IMDSv2 is unreachable or disabled on the EC2 instances, the logs are filled with such messages without providing any real value or action as the application fallbacks to IMDSv1 anyway. We can move such messages to the debug level in order to try and keep the log messages clean for any warnings that might be missed with this flooding. These messages probably fail into the debug category anyway as they are mostly helpful when debugging the application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If IMDSv2 is unreachable or disabled on the EC2 instances, the logs
are filled with such messages without providing any real value or action
as the application fallbacks to IMDSv1 anyway. We can move such messages
to the debug level in order to try and keep the log messages clean for
any warnings that might be missed with this flooding.
These messages probably fail into the debug category anyway as they are
mostly helpful when debugging the application.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.