Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix release prep for gh actions #343

Merged
merged 2 commits into from
Jan 7, 2021
Merged

fix release prep for gh actions #343

merged 2 commits into from
Jan 7, 2021

Conversation

brycahta
Copy link
Contributor

@brycahta brycahta commented Jan 6, 2021

Issue #, if available:

  • Last release failed in 2 areas:
    • the chart version was not incremented in the eks-charts PR
    • gh actions errored out when trying to publish version updates to ReadMe (post release)
      • one reason being previousVersion == latestVersion

Description of changes:

  • Updated make release-prep-X to increment Chart.yaml version as part of the Release-Prep PR
  • If previousVersion == latestVersion, then fetch previous-previous version
  • Add git config for ec2-bot
  • Update sed replacement to work with Mac and Linux
  • Circumvent pr-publish-prompt when updating ReadMe only (triggered by bot and considered post-release)
  • Exit gracefully when no file changes required

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bwagner5
Copy link
Contributor

bwagner5 commented Jan 6, 2021

e2e k8s 1.17 failure is just due to ec2-metadata-mock docker image pull issue which should be fixed with aws/amazon-ec2-metadata-mock#116

2021/01/06 23:08:21 ??? There was a problem monitoring for events error="There was a problem checking for spot ITNs: Unable to parse metadata response: Unable to get a response from IMDS: Get \"http://amazon-ec2-metadata-mock-service.default.svc.cluster.local:1355/latest/meta-data/spot/instance-action\": dial tcp 10.96.185.117:1355: connect: connection refused" event_type=SPOT_ITN
2021/01/06 23:08:21 ??? Trying to get token from IMDSv2
2021/01/06 23:08:22 ??? Unable to retrieve an IMDSv2 token, continuing with IMDSv1 error="Put \"http://amazon-ec2-metadata-mock-service.default.svc.cluster.local:1355/latest/api/token\": dial tcp 10.96.185.117:1355: connect: connection refused"
2021/01/06 23:08:23 ??? Request failed. Attempts remaining: 1
2021/01/06 23:08:23 ??? Sleep for 5.344459842s seconds
2021/01/06 23:08:23 ??? Request failed. Attempts remaining: 2
2021/01/06 23:08:23 ??? Sleep for 2.151964631s seconds
2021/01/06 23:08:26 ??? Request failed. Attempts remaining: 1
2021/01/06 23:08:26 ??? Sleep for 5.985257801s seconds
2021/01/06 23:08:29 ??? There was a problem monitoring for events error="Unable to parse metadata response: Unable to parse metadata response: Unable to get a response from IMDS: Get \"http://amazon-ec2-metadata-mock-service.default.svc.cluster.local:1355/latest/meta-data/events/maintenance/scheduled\": dial tcp 10.96.185.117:1355: connect: connection refused" event_type=SCHEDULED_EVENT
2021/01/06 23:08:29 ??? Trying to get token from IMDSv2
2021/01/06 23:08:30 ??? Unable to retrieve an IMDSv2 token, continuing with IMDSv1 error="Put \"http://amazon-ec2-metadata-mock-service.default.svc.cluster.local:1355/latest/api/token\": dial tcp 10.96.185.117:1355: connect: connection refused"
2021/01/06 23:08:31 ??? Request failed. Attempts remaining: 2
2021/01/06 23:08:31 ??? Sleep for 2.442480269s seconds
⏰ Took 1491sec
❌ NTH Integration Test FAILED nth-test-cebb2aa4! ❌
🥑 Deleting k8s cluster using "kind"
Deleting cluster "nth-test-cebb2aa4" ...

@brycahta
Copy link
Contributor Author

brycahta commented Jan 7, 2021

@brycahta brycahta merged commit e7fab60 into aws:main Jan 7, 2021
@brycahta brycahta deleted the release-fixn branch January 7, 2021 18:40
haugenj pushed a commit to haugenj/aws-node-termination-handler that referenced this pull request Feb 19, 2021
* fix release prep for gh actions

* increment AEMM to latest ecr image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants