Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove + from major minor server version #195

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Conversation

bwagner5
Copy link
Contributor

Issue #, if available:
#193

Description of changes:

  • Fix semver comparison in the helm chart when the server provider's major number includes a "+" like in the case of EKS.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2020

Codecov Report

Merging #195 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #195   +/-   ##
=======================================
  Coverage   81.26%   81.26%           
=======================================
  Files          10       10           
  Lines         774      774           
=======================================
  Hits          629      629           
  Misses        129      129           
  Partials       16       16           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc39bfb...1b309f1. Read the comment docs.

@bwagner5 bwagner5 requested a review from cjerad July 10, 2020 15:30
Copy link
Contributor

@cjerad cjerad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@cjerad cjerad merged commit 43a69e0 into aws:master Jul 10, 2020
@bwagner5 bwagner5 deleted the fix-semver branch July 15, 2020 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants