Add back deprecated flags for checking whether an instance is managed…

… by NTH (#686) We removed these flags in NTH release v1.17.0, but they are still supported for now. The Helm chart should support both in the mean time.
aws · Sep 13, 2022 · b347469 · b347469
1 parent 7547519
commit b347469
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/config/helm/aws-node-termination-handler/templates/deployment.yaml b/config/helm/aws-node-termination-handler/templates/deployment.yaml
@@ -82,8 +82,14 @@ spec:
               value: {{ .Values.enablePrometheusServer | quote }}
             - name: PROMETHEUS_SERVER_PORT
               value: {{ .Values.prometheusServerPort | quote }}
+            # [DEPRECATED] Use CHECK_TAG_BEFORE_DRAINING instead
+            - name: CHECK_ASG_TAG_BEFORE_DRAINING
+              value: {{ .Values.checkASGTagBeforeDraining | quote }}
             - name: CHECK_TAG_BEFORE_DRAINING
               value: {{ .Values.checkTagBeforeDraining | quote }}
+            # [DEPRECATED] Use MANAGED_TAG instead
+            - name: MANAGED_ASG_TAG
+              value: {{ .Values.managedAsgTag | quote }}
             - name: MANAGED_TAG
               value: {{ .Values.managedTag | quote }}
             - name: USE_PROVIDER_ID

diff --git a/config/helm/aws-node-termination-handler/values.yaml b/config/helm/aws-node-termination-handler/values.yaml
@@ -173,9 +173,15 @@ queueURL: ""
 # The maximum amount of parallel event processors to handle concurrent events
 workers: 10
 
+# [DEPRECATED] Use checkTagBeforeDraining instead
+checkASGTagBeforeDraining: true
+
 # If true, check that the instance is tagged with "aws-node-termination-handler/managed" as the key before draining the node
 checkTagBeforeDraining: true
 
+# [DEPRECATED] Use managedTag instead
+managedAsgTag: "aws-node-termination-handler/managed"
+
 # The tag to ensure is on a node if checkTagBeforeDraining is true
 managedTag: "aws-node-termination-handler/managed"