User-defined log stream prefix (issue #83) #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaytaybai
reviewed
May 8, 2019
klaytaybai
reviewed
May 8, 2019
|
@bartpio, thanks for working on this. I'm curious on anyone's opinion of whether setting a non-empty custom prefix and an empty custom suffix should remove the hyphen '-' that would otherwise exist between the date and the suffix. |
|
I have merged this into the dev branch to go out with the next release. |
|
All of the logging libraries have been released with this PR. Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #83
Added LogStreamPrefix to allow the library user, optionally, to specify a user-defined segment of the log stream prefix. If specified, the log stream name will begin with this user-defined segment, followed by the system-defined prefix segment of the yyyy/mm/dd form, then followed by the suffix (user defined or system defined, as in prior state).
Enhanced unit tests for all supported unit test frameworks to test LogStreamPrefix in a manner similar to the pre-existing LogStreamSuffix.
The design invariant that a unique date-based component be included in the log stream name is maintained.
Backwards compatibility is maintained, as leaving the LogStreamPrefix null or empty results in behavior identical to the prior state.
As per design of the CloudWatch log stream enumeration API, this allows for significantly more efficient filtered enumeration of log streams within a log group, when the user wants to filter by a meaningful (rather than date-based) prefix. see logStreamNamePrefix property
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.