NLog AWSTarget apply Layout logic for AuthenticationRegion #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ci: Add AWS CI workflow for running unit and integ tests
Sync dev to master
ashishdhingra
approved these changes
May 14, 2024
There was a problem hiding this comment.
Looks good. AuthenticationRegion needs to use SimpleLayout logic similar to other properties (like Region). SimpleLayout provides more details.
Apologies for the miss.
normj
approved these changes
May 14, 2024
|
The PR was released this morning as part of version 3.3.3 of the |
|
Wow that was quick. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #255
Description of changes:
Followup to #260 where NLog Layout Logic is applied for AuthenticationRegion
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.