Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing xml namespace declarations to POM files #97

Merged
merged 1 commit into from
Sep 2, 2019
Merged

Add missing xml namespace declarations to POM files #97

merged 1 commit into from
Sep 2, 2019

Commits on Sep 2, 2019

  1. Add missing xml namespace declarations to POM files 

    Without these declarations, the XML file cannot be validated correctly.

See examples:

* <https://maven.apache.org/pom.html#Quick_Overview>
* <https://github.com/aws/aws-sdk-java-v2/blob/master/aws-sdk-java/pom.xml>

The tool I'm using actually tries to validate these before using them
(<https://tiny.amazon.com/ibdzmlln/paste> -- Amazon internal link), so
that's why I ran into issues. I'm assuming most tools don't have the
validation enabled, so this is why others haven't reported this before.

The same issue can be easily replicated by pasting the current POM
files in <https://www.w3schools.com/xml/xml_validator.asp> as well
as just trying to open them with Firefox.

(P.s: Hello there Lambda team! We recently met in your Dublin office!)
    @ivoanjo
    ivoanjo committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    2deaa6a View commit details
    Browse the repository at this point in the history