Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rotation Token for SecretsManager Rotation Event #520

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

hannah-nguyen-ca
Copy link
Contributor

@hannah-nguyen-ca hannah-nguyen-ca commented Feb 3, 2025

Issue #, if available: RotationToken was introduced to SecretsManager Rotation Event.

Description of changes: Add RotationToken field to SecretsManager Rotation Event.

Target (OCI, Managed Runtime, both): both

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@maxday
Copy link
Contributor

maxday commented Feb 4, 2025

Thank you, can you please bump the pom version so we release? I think bumping minor would make sense? Can you also please update aws-lambda-java-events/RELEASE.CHANGELOG.md

@godcrampy
Copy link
Contributor

I've just merged a PR (#519 ) which bumps the minor version of events package to 3.15.0. We can release these changes with the same version. Please update the changelog in aws-lambda-java-events/RELEASE.CHANGELOG.md with the changes from this PR.

@godcrampy godcrampy self-requested a review February 5, 2025 16:53
Copy link
Contributor

@godcrampy godcrampy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@godcrampy godcrampy merged commit cfb3ece into aws:main Feb 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants