Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name of s3Bucket field of Task class in S3BatchEventV2 #506

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

mmerfort
Copy link
Contributor

@mmerfort mmerfort commented Aug 9, 2024

Description of changes:

Fix the name of the s3Bucket field, which was previously incorrect. Add a test for that specific field.

Target (OCI, Managed Runtime, both):
unknown

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@maxday maxday self-requested a review August 9, 2024 10:23
Copy link
Contributor

@maxday maxday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smirnoal
Copy link
Contributor

smirnoal commented Aug 9, 2024

can you please share a link to public doc with the correct name?

@mmerfort
Copy link
Contributor Author

Documentation on this topic seems a bit sparse and this is the only thing I could find: https://aws.amazon.com/blogs/storage/automate-object-processing-in-amazon-s3-directory-buckets-with-s3-batch-operations-and-aws-lambda/

@smirnoal smirnoal merged commit ca565bc into aws:main Aug 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants