Skip to content

Commit

Permalink
Add missing xml namespace declarations to POM files (#97)
Browse files Browse the repository at this point in the history
Without these declarations, the XML file cannot be validated correctly.

See examples:

* <https://maven.apache.org/pom.html#Quick_Overview>
* <https://github.com/aws/aws-sdk-java-v2/blob/master/aws-sdk-java/pom.xml>

The tool I'm using actually tries to validate these before using them
(<https://tiny.amazon.com/ibdzmlln/paste> -- Amazon internal link), so
that's why I ran into issues. I'm assuming most tools don't have the
validation enabled, so this is why others haven't reported this before.

The same issue can be easily replicated by pasting the current POM
files in <https://www.w3schools.com/xml/xml_validator.asp> as well
as just trying to open them with Firefox.

(P.s: Hello there Lambda team! We recently met in your Dublin office!)
  • Loading branch information
ivoanjo authored and bmoffatt committed Sep 2, 2019
1 parent b45419d commit 389461a
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 4 deletions.
4 changes: 3 additions & 1 deletion aws-lambda-java-core/pom.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/maven-v4_0_0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>

<groupId>com.amazonaws</groupId>
Expand Down
4 changes: 3 additions & 1 deletion aws-lambda-java-events/pom.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/maven-v4_0_0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>

<groupId>com.amazonaws</groupId>
Expand Down
4 changes: 3 additions & 1 deletion aws-lambda-java-log4j/pom.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/maven-v4_0_0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>

<groupId>com.amazonaws</groupId>
Expand Down
4 changes: 3 additions & 1 deletion aws-lambda-java-log4j2/pom.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/maven-v4_0_0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>

<groupId>com.amazonaws</groupId>
Expand Down

0 comments on commit 389461a

Please sign in to comment.