Add usernameParameter to CognitoEventUserPoolsCustomMessageRequest #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CustomMessage_AdminCreateUser trigger returns a user name and verification code, so the request must include both request.usernameParameter and request.codeParameter. Add the usernameParameter field to the CognitoEventUserPoolsCustomMessageRequest struct to meet this requirement. https://docs.aws.amazon.com/cognito/latest/developerguide/user-pool-lambda-custom-message.html
Codecov Report
@@ Coverage Diff @@
## master #219 +/- ##
=======================================
Coverage 75.88% 75.88%
=======================================
Files 18 18
Lines 647 647
=======================================
Hits 491 491
Misses 115 115
Partials 41 41Continue to review full report at Codecov.
|
bmoffatt
approved these changes
Aug 7, 2019
|
Can you please merge this? |
|
Done! Thanks for the contribution! |
|
Great - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
I did not open an issue for this because the fix is quick.
Description of changes:
The CustomMessage_AdminCreateUser trigger returns a user name and verification code, so the request must include both request.usernameParameter and request.codeParameter. Add the usernameParameter field to the CognitoEventUserPoolsCustomMessageRequest struct to meet this requirement.
https://docs.aws.amazon.com/cognito/latest/developerguide/user-pool-lambda-custom-message.html
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.