Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle the nil pointer exception in writeKubeconfig when no cluster r… #530

Merged
merged 1 commit into from
Dec 23, 2024
Merged

handle the nil pointer exception in writeKubeconfig when no cluster r… #530

merged 1 commit into from
Dec 23, 2024

Conversation

wwvela
Copy link
Contributor

@wwvela wwvela commented Dec 23, 2024

Issue #, if available:

  • Handle the nil pointer exception in writeKubeconfig method when we didn't set --up flag and --static-cluster-name in kubetest2 command and the cluster pass to writeKubeconfig will be nil.

@mattcjo
Copy link
Contributor

mattcjo commented Dec 23, 2024

LGTM

@mattcjo mattcjo self-assigned this Dec 23, 2024
@mattcjo mattcjo self-requested a review December 23, 2024 17:26
@mattcjo mattcjo removed their assignment Dec 23, 2024
@mattcjo mattcjo merged commit cb370ed into aws:main Dec 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcjo mattcjo mattcjo approved these changes

@cartermckinnon cartermckinnon Awaiting requested review from cartermckinnon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wwvela @mattcjo