Create placeholder deployment for Auto clusters if --nodes > 0 #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermckinnon
commented
Dec 13, 2024
| @@ -189,7 +189,7 @@ func (d *deployer) Up() error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| if d.deployerOptions.StaticClusterName != "" || d.deployerOptions.AutoMode { | |||
| if d.deployerOptions.StaticClusterName != "" { | |||
There was a problem hiding this comment.
This was a bug -- the staticClusterManager was likely nil if --auto-mode was used.
cartermckinnon
force-pushed
the
auto-mode-nodes
branch
from
2ac3d1f to
ea86b55
Compare
tzneal
reviewed
Dec 13, 2024
tzneal
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This refactors the
NodegroupManagerinto a more generalNodeManagerthat supports EKS Auto. A "placeholder" deployment will be created that makes the--nodesflag effective when--auto-modeis used.There's a similar thing being done for
--static-cluster-name. That will be removed in later PR's; I haven't touched that behavior so that CI jobs can be migrated without breakage.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.