Run Greengrass Basic Discovery in CI #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiazhvera
approved these changes
Jun 6, 2023
|
Thanks! Merging into (Will tackle the warning mentioned in #427 in another PR - the issue is unrelated to the sample itself) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds running the Greengrass discovery sample in CI. It also unifies the command line options with the Python SDK, which allows for only printing the discovery information. Now the sample has been adjusted to print the discovery information and, if the option is set, it will only print the discovery information. Previously the sample didn't print the discovery information at all. I tried to make the print format similar to Python.
This PR also changes the sample a bit so it doesn't require passing a CA file (though it still works if you pass one) and removes checks to make sure the input files are present, as none of the other samples do this and on the CRT layer we print if the files are missing - making it redundant.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.