Ota/fix sudo issue #1487
Merged
Ota/fix sudo issue #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Shubham Divekar <divekarshubham@gmail.com>
divekarshubham
previously approved these changes
Dec 12, 2020
cobusve
previously approved these changes
Dec 13, 2020
* Update OTA PAL include guard names * Add unit test cases for getcwd failing * Add unit test helper functions for getcwd pass/fail
…nto ota/fix_sudo_issue
yanjos-dev
previously approved these changes
Dec 13, 2020
gkwicker
suggested changes
Dec 13, 2020
There was a problem hiding this comment.
See comments – also this new code contains 3 copies of essentially identical code to construct a fully-qualified pathname. That should be factored into a static utility method and reused in this module. This will make the code less complex, more readable, and easier to test.
gkwicker
suggested changes
Dec 13, 2020
gkwicker
previously requested changes
Dec 14, 2020
cobusve
reviewed
Dec 14, 2020
cobusve
reviewed
Dec 14, 2020
…k-embedded-C into ota/fix_sudo_issue
cobusve
approved these changes
Dec 14, 2020
yanjos-dev
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.