Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTA library and PAL #1412

Merged
merged 172 commits into from
Dec 4, 2020
Merged

Add OTA library and PAL #1412

merged 172 commits into from
Dec 4, 2020

Conversation

tgsong
Copy link
Contributor

@tgsong tgsong commented Nov 30, 2020

Issue #, if available:

Description of changes:

  • Add OTA library as a submodule
  • Add OTA PAL for posix

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Tiangang Song and others added 30 commits July 13, 2020 16:10
divekarshubham
divekarshubham previously approved these changes Dec 4, 2020
platform/posix/ota_pal/source/ota_pal_posix.c Outdated Show resolved Hide resolved
platform/posix/ota_pal/source/ota_pal_posix.c Outdated Show resolved Hide resolved
platform/posix/ota_pal/source/ota_pal_posix.c Show resolved Hide resolved
platform/posix/ota_pal/source/ota_pal_posix.c Show resolved Hide resolved
platform/posix/ota_pal/source/ota_pal_posix.c Outdated Show resolved Hide resolved
platform/posix/ota_pal/source/ota_pal_posix.c Outdated Show resolved Hide resolved
platform/posix/ota_pal/utest/ota_config.h Outdated Show resolved Hide resolved
cobusve
cobusve previously approved these changes Dec 4, 2020
Copy link
Contributor

@gkwicker gkwicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

platform/lexicon.txt Outdated Show resolved Hide resolved
platform/lexicon.txt Outdated Show resolved Hide resolved
platform/posix/ota_pal/source/include/ota_pal_posix.h Outdated Show resolved Hide resolved
platform/posix/ota_pal/source/ota_pal_posix.c Outdated Show resolved Hide resolved
platform/posix/ota_pal/source/ota_pal_posix.c Outdated Show resolved Hide resolved
platform/posix/ota_pal/source/ota_pal_posix.c Outdated Show resolved Hide resolved
platform/posix/ota_pal/source/ota_pal_posix.c Outdated Show resolved Hide resolved
platform/posix/ota_pal/utest/ota_config.h Show resolved Hide resolved
* @brief Test that otaPal_WriteBlock will return correct result code.
*/
void test_OTAPAL_WriteBlock_FseekError( void )
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be implemented? This seems like an important test to have.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be addressed in further PR from @yanjos-dev

Comment on lines +316 to +322
{
}

void test_OTAPAL_CloseFile_ValidSignature( void )
{
OtaPalMainStatus_t result;
int16_t bytes_written = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be implemented? This seems like an important test to have.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be addressed in further PR from @yanjos-dev

@tgsong tgsong dismissed stale reviews from cobusve and divekarshubham via 758a7ae December 4, 2020 20:36
Copy link
Contributor

@gkwicker gkwicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small things, see comments

demos/lexicon.txt Outdated Show resolved Hide resolved
demos/lexicon.txt Outdated Show resolved Hide resolved
@@ -370,6 +396,7 @@ pkcs
pki
pkparse
pkwrite
plaformimagestate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling: platformimagestage

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is platform image state, we have valid, invalid, pending commit states I believe.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, but the t is missing from "platform",

platform/lexicon.txt Outdated Show resolved Hide resolved
gkwicker
gkwicker previously approved these changes Dec 4, 2020
Comment on lines +1 to +7
set(OPENSSL_USE_STATIC_LIBS TRUE)
find_package(OpenSSL REQUIRED)

set(THREADS_PREFER_PTHREAD_FLAG ON)
find_package(Threads REQUIRED)

find_library(LIB_RT rt REQUIRED)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these for? If this is being introduced in this PR, can I assume it is only required by the OTA PAL? In that case would it make sense to move this to the OTA PAL specific CMakeLists.txt instead of this one?

@tgsong tgsong merged commit 0203d48 into aws:main Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants