-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OTA library and PAL #1412
Add OTA library and PAL #1412
Conversation
Submodule JSMN to v1.1.0
submodule tinycbor to v0.5.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
* @brief Test that otaPal_WriteBlock will return correct result code. | ||
*/ | ||
void test_OTAPAL_WriteBlock_FseekError( void ) | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be implemented? This seems like an important test to have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be addressed in further PR from @yanjos-dev
{ | ||
} | ||
|
||
void test_OTAPAL_CloseFile_ValidSignature( void ) | ||
{ | ||
OtaPalMainStatus_t result; | ||
int16_t bytes_written = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be implemented? This seems like an important test to have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be addressed in further PR from @yanjos-dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few small things, see comments
demos/lexicon.txt
Outdated
@@ -370,6 +396,7 @@ pkcs | |||
pki | |||
pkparse | |||
pkwrite | |||
plaformimagestate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spelling: platformimagestage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is platform image state, we have valid, invalid, pending commit states I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, but the t is missing from "platform",
set(OPENSSL_USE_STATIC_LIBS TRUE) | ||
find_package(OpenSSL REQUIRED) | ||
|
||
set(THREADS_PREFER_PTHREAD_FLAG ON) | ||
find_package(Threads REQUIRED) | ||
|
||
find_library(LIB_RT rt REQUIRED) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are these for? If this is being introduced in this PR, can I assume it is only required by the OTA PAL? In that case would it make sense to move this to the OTA PAL specific CMakeLists.txt instead of this one?
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.