Thing Shadow: Fix potential shadow buffer overflow #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potential overflow occurs if SHADOW_MAX_SIZE_OF_RX_BUFFER is overriden to less than the default (AWS_IOT_MQTT_RX_BUF_LEN+1).
projectgus
force-pushed
the
bugfix/thing_shadow_overflow
branch
from
2539def to
19f92c9
Compare
|
Hi @projectgus , |
gordonwang0
pushed a commit
that referenced
this pull request
Apr 20, 2018
Potential overflow occurs if SHADOW_MAX_SIZE_OF_RX_BUFFER is overriden to less than the default (AWS_IOT_MQTT_RX_BUF_LEN+1).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't a problem for the default SHADOW_MAX_SIZE_OF_RX_BUFFER value, as the payload will be at most AWS_IOT_MQTT_RX_BUF_LEN bytes so there is room for the NULL byte. However if this value is changed to any lower value, it can overflow when writing the terminal NULL byte.
Thanks!