chore(release): update changelog and identifiers.py #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Fixes | ||
| ----------- | ||
| * fix: Handle errors when decrypting multiple EDKs with raw RSA MKPs (#672 (https://github.com/aws/aws-encryption-sdk-python/pull/672)) |
There was a problem hiding this comment.
Can you add the commit as well like in previous changelog entries?
Suggested change
| * fix: Handle errors when decrypting multiple EDKs with raw RSA MKPs (#672 (https://github.com/aws/aws-encryption-sdk-python/pull/672)) | |
| * fix: Handle errors when decrypting multiple EDKs with raw RSA MKPs (#672 (https://github.com/aws/aws-encryption-sdk-python/pull/672)) (5f29be9(https://github.com/josecorella/aws-encryption-sdk-python/commit/5f29be92e8e54202a00f13aee6f1c70fb22a6b38)) |
There was a problem hiding this comment.
I couldn't find an automated way to generate the changelog. Given that it's manually written I think adding both the things wouldn't scale and doesn't add any value as well. I chose to add PR link because it has more details and you can anyway refer to the commit from there.
Also if you scroll below you'd see that the format is flexible for the changelog. I'll also check how it was generated the last time - but if it was manual indeed I don't think we should add both.
lucasmcdonald3
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
chore(release): update changelog and identifiers.py for v3.3.0
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: