Fix permissions issue on install, and update revision version number. #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsb42-aws
approved these changes
Nov 22, 2017
There was a problem hiding this comment.
Yup, this should do it. To be honest I'm not entirely sure why I had those in as data_files in setup.py to begin with.
For some context, MANIFEST.in determines what is included in the sdist build, which is where those files are needed. setup.py data_files determines extra files that are actually installed from the dist file, and these files do not need to be installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #122
Testing:
setup.py sdist+pip install aws-encryption-sdk-cli*.tar.gz)MANIFEST.inand verified output .tar.gz still includes metadata files (README.rst,CHANGELOG.rst,LICENSE,requirements.txt)Assigning @mattsb42-aws as reviewer -- it's possible there's something I've missed here such that this isn't the right fix, but I think this might do it and I wanted to get a PR out ASAP to help prevent people from being blocked on install.