-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] Implement CLI command benchmark harness script #9278
base: v2
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attempting to run these for me is resulting in
(.venv312) ➜ performance git:(benchmarks) ✗ ./run-benchmarks
Traceback (most recent call last):
File "/Users/shovlia/GitHub/aws-cli/scripts/performance/./run-benchmarks", line 38, in <module>
harness.run_benchmarks(parser.parse_args())
File "/Users/shovlia/GitHub/aws-cli/scripts/performance/benchmark_utils.py", line 410, in run_benchmarks
measurements = self._run_isolated_benchmark(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/shovlia/GitHub/aws-cli/scripts/performance/benchmark_utils.py", line 351, in _run_isolated_benchmark
with open(child_output_path, 'w') as out, open(child_err_path, 'w') as err:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'results/assets/output.txt'
Traceback (most recent call last):
File "/Users/shovlia/GitHub/aws-cli/scripts/performance/./run-benchmarks", line 38, in <module>
harness.run_benchmarks(parser.parse_args())
File "/Users/shovlia/GitHub/aws-cli/scripts/performance/benchmark_utils.py", line 410, in run_benchmarks
measurements = self._run_isolated_benchmark(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/shovlia/GitHub/aws-cli/scripts/performance/benchmark_utils.py", line 366, in _run_isolated_benchmark
raise RuntimeError('Child process execution failed: output file not found.')
RuntimeError: Child process execution failed: output file not found.
It looks like you're missing the changes from #9264 somehow? I only see the S3 tests in |
Fixed in latest revision, thanks |
Description of changes:
No changes apart from those in the reviewed PRs linked above are included in this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.