[v2] Add s3 integration tests using directory buckets #8794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hssyoo
force-pushed
the
s3-express-integ-tests
branch
from
8872d28
to
c5bb69e
Compare
nateprewitt
reviewed
Jul 11, 2024
awscli/testutils.py
Outdated
Comment on lines
189
to
193
| if not region: | ||
| region = 'us-west-2' | ||
| client = session.create_client('s3', region_name=region) | ||
| if not az: | ||
| az = 'usw2-az1' |
There was a problem hiding this comment.
We might consider making the region and az input a tuple since they're inherently bound. i.e. if I pass us-east-1 but forget to add the az, I don't think we want those disjoint, do we?
Something like this:
Suggested change
| if not region: | |
| region = 'us-west-2' | |
| client = session.create_client('s3', region_name=region) | |
| if not az: | |
| az = 'usw2-az1' | |
| if not location: | |
| location = ('us-west-2', 'usw2-az1') | |
| region, az = location | |
| client = session.create_client('s3', region_name=region) |
nateprewitt
approved these changes
Jul 11, 2024
kdaily
requested changes
Jul 17, 2024
| """ | ||
| if not location: | ||
| location = ('us-west-2', 'usw2-az1') | ||
| region, az = location |
There was a problem hiding this comment.
nit: name the parameter availability_zone instead of az to avoid using abbreviations.
| @@ -181,6 +181,45 @@ def create_bucket(session, name=None, region=None): | |||
| return bucket_name | |||
|
|
|||
|
|
|||
| def create_dir_bucket(session, name=None, location=None): | |||
There was a problem hiding this comment.
It would be helpful to a developer to put a docstring for the type of location, since its a tuple.
| s3_utils.delete_bucket(bucket_name) | ||
|
|
||
|
|
||
| @pytest.fixture(scope='package') |
There was a problem hiding this comment.
Document this the same as shared_copy_bucket:
# Directory bucket for cross-S3 copies
kdaily
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up S3 directory bucket creation/teardown for integration tests with high-level
s3commands. For the existing teardown logic to be compatible with directory buckets, we switch fromListObjectstoListObjectsV2when clearing out test buckets.