Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds --size-only param to aws s3 sync to allow syncing by filesize only. #719

Merged
merged 1 commit into from
Apr 4, 2014

Conversation

johnboxall
Copy link
Contributor

Based heavily off #575, implements the --size-only param as discussed in #473 and #599.

@johnboxall johnboxall changed the title Implements #473, adding a --size-only param to aws s3 sync Adds --size-only param to aws s3 sync to allow syncing by filesize only. Mar 22, 2014
@jamesls
Copy link
Member

jamesls commented Mar 24, 2014

Thanks, this looks good to me. I think we should just add one more test, for when src_time > dst_time and sizes are equal.

@johnboxall
Copy link
Contributor Author

@jamesls I've added the suggested test in my new commit.

I've opted for the non-DRY style here as it seems to be the pattern set by the rest of the tests in test_comparator.

@jamesls
Copy link
Member

jamesls commented Apr 3, 2014

@johnboxall Thanks for the pull request, I think it looks great. Sorry for the delay. I've been asked to obtain a signed CLA for this contribution. Would you mind emailing me at the address in my github profile so I can send you the CLA. Thanks.

jamesls added a commit that referenced this pull request Apr 4, 2014
@jamesls jamesls merged commit 213f402 into aws:develop Apr 4, 2014
@jamesls
Copy link
Member

jamesls commented Apr 4, 2014

Merged, thanks again for the contribution.

@jamesls jamesls mentioned this pull request Apr 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants