Use a single IO thread when downloading S3 objects #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have seen issues on some OSes that have trouble with concurrent IO threads to different parts of the same file. Despite these being non overlapping parts of the file, this doesn't always work. The fix is to switch to a single IO thread. All other threads are now passed an IO queue in which they can submit either `IORequests` or `IOCompleteRequests` that the IO thread understands.
|
LGTM. I was wondering how much of an impact this had on download performance? |
|
LGTM as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen issues on some OSes that have trouble with
concurrent IO threads to different parts of the same file.
Despite these being non overlapping parts of the file, this
doesn't always work.
The fix is to switch to a single IO thread. All other threads are
now passed an IO queue in which they can submit either
IORequestsor
IOCompleteRequeststhat the IO thread understands.Fixes #619