Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(toolkit): multi-stack apps cannot be synthesized or deployed #911

Merged
merged 2 commits into from
Oct 12, 2018
Merged

fix(toolkit): multi-stack apps cannot be synthesized or deployed #911

merged 2 commits into from
Oct 12, 2018

Commits on Oct 12, 2018

  1. fix(toolkit): commands wouldn't work against the selected stacks (reg… 

    …ression)

Due to a recent cx protocol change (#868), some toolkit commands stopped
respecting the "selected" stacks (the ones specified in the command line).

"cdk synth" would always return the first stack, and "cdk deploy" would
always deploy all stacks.

Since we have test coverage gaps in the toolkit (#294), we did not
discover this before we released.

This change includes an initial set of integration tests for the 
toolkit. At the moment they should be manually executed when toolkit
changes are made, but we will execute them in a pipeline.

Fixes #910
    Elad Ben-Israel committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    3427b72 View commit details
    Browse the repository at this point in the history

  2. Remove package.json from integ test app 

    Otherwise, lerna thinks it's a real module and gets really confused
    Elad Ben-Israel committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    a7ddf97 View commit details
    Browse the repository at this point in the history