chore(cloudfront): convert tests to Jest #8939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following in the example of #8811 and the aws-ec2 conversion, converting the aws-cloudfront tests to Jest in preparation for adding new tests.
njlynch
commented
Jul 8, 2020
| new CloudFrontWebDistribution(stack, 'Distribution', { | ||
| originConfigs: [{ | ||
| behaviors: [{ isDefaultBehavior: true }], | ||
| connectionTimeout: cdk.Duration.seconds(-1), |
There was a problem hiding this comment.
Note: Duration.seconds(-1) throws an exception, making this test fail for the wrong reason. Deleted it as unnecessary.
eladb
approved these changes
Jul 8, 2020
rix0rrr
approved these changes
Jul 8, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following in the example of #8811 and the aws-ec2 conversion, converting the
aws-cloudfront tests to Jest in preparation for adding new tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license