Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(s3-deployment): prune - keep missing files on destination bucket #8263

Merged
merged 18 commits into from
Jul 5, 2020
Merged

feat(s3-deployment): prune - keep missing files on destination bucket #8263

merged 18 commits into from
Jul 5, 2020

Conversation

iliapolo
Copy link
Contributor

@iliapolo iliapolo commented May 28, 2020 •
edited by eladb
Loading

Introduce a prune property that eventually controls the --delete flag when invoking the aws s3 sync command.

Resolves #953

In addition, migrate the module from nodeunit to jest.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 28, 2020
@agdimech
Copy link

+1 -Need this feature in order to support deployment of some cached vs non-cached files.

@agdimech
Copy link

Any update on this PR?

@iliapolo
Copy link
Contributor Author

Not abandoned. I hope to return to it this week.

iliapolo
iliapolo commented Jul 4, 2020
View reviewed changes
packages/@aws-cdk/aws-s3-deployment/README.md
@@ -59,10 +59,40 @@ all but a single file:

## Retain on Delete

By default, the contents of the destination bucket will be deleted when the
By default, the contents of the destination bucket will **not** be deleted when the
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this because apparently the default behavior was changed in this PR, but the README was not updated.

@iliapolo iliapolo marked this pull request as ready for review July 4, 2020 02:13
@iliapolo iliapolo requested a review from a team July 4, 2020 02:13
eladb
eladb reviewed Jul 5, 2020
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think prune should be sufficient for a name. What value do we get from the onDeployment part of the name?

@iliapolo
Copy link
Contributor Author

iliapolo commented Jul 5, 2020

I think prune should be sufficient for a name. What value do we get from the onDeployment part of the name?

@eladb Its just a tad more accurate. I also liked the consistency with retainOnDelete.

@iliapolo iliapolo requested a review from eladb July 5, 2020 13:03
@eladb eladb changed the title feat(s3-deployment): option to keep missing files on destination bucket feat(s3-deployment): prune - keep missing files on destination bucket Jul 5, 2020
eladb
eladb suggested changes Jul 5, 2020
View reviewed changes
packages/@aws-cdk/aws-s3-deployment/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-s3-deployment/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-s3-deployment/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-s3-deployment/lib/bucket-deployment.ts Show resolved Hide resolved
@iliapolo iliapolo requested a review from eladb July 5, 2020 17:28
@mergify
Copy link
Contributor

mergify bot commented Jul 5, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jul 5, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 57914c7 into master Jul 5, 2020
@mergify mergify bot deleted the epolon/disable-sync-delete-s3-deployment branch July 5, 2020 17:51
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: bf92e03
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees

@iliapolo iliapolo

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

s3-deployment: allow disabling "sync --delete"
4 participants
@iliapolo @agdimech @aws-cdk-automation @eladb