Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aws-cloudfront): Fix loggingConfig being ignored #809

Merged
merged 11 commits into from
Oct 2, 2018
Merged

fix(aws-cloudfront): Fix loggingConfig being ignored #809

merged 11 commits into from
Oct 2, 2018

Commits on Sep 28, 2018

  1. fix(aws-cloudfront): Fix loggingConfig being ignored 

    feat(aws-s3): Add support for domainName on BucketRef instead of just Bucket

LoggingConfiguration now requires bucket instead of it being optional. There is no point to including a LoggingConfiguration without a bucket (no-breaking).

Fixes aws#721
    Blake Price committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    ac09b96 View commit details
    Browse the repository at this point in the history

  2. Update docstring to be in line with standards

    @rix0rrr
    rix0rrr authored Sep 28, 2018
    Configuration menu
    Copy the full SHA
    43516c5 View commit details
    Browse the repository at this point in the history

  3. Fix docstring format for LoggingConfiguration

    @rix0rrr
    rix0rrr authored Sep 28, 2018
    Configuration menu
    Copy the full SHA
    7a44981 View commit details
    Browse the repository at this point in the history

  4. Fix whitespace errors

    @rix0rrr
    rix0rrr authored Sep 28, 2018
    Configuration menu
    Copy the full SHA
    cb52b3a View commit details
    Browse the repository at this point in the history

  5. Fix whitespace errors with S3 

    Auto generate logging bucket if one is not provided + tests
    Blake Price committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    24723ed View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into cloudfront-s3-fix

    Blake Price committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    46ceadf View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2018

  1. Update default s3 bucket name

    Blake Price committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    b8a4e14 View commit details
    Browse the repository at this point in the history

  2. Update tests

    Blake Price committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    1535e48 View commit details
    Browse the repository at this point in the history

  3. Fix parent for on-the-spot created Logging Bucket

    @rix0rrr
    rix0rrr authored Oct 1, 2018
    Configuration menu
    Copy the full SHA
    bec5142 View commit details
    Browse the repository at this point in the history

  4. Assign to this.loggingBucket

    @rix0rrr
    rix0rrr authored Oct 1, 2018
    Configuration menu
    Copy the full SHA
    ed88a02 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2018

  1. Update test expectation

    @rix0rrr
    rix0rrr authored Oct 2, 2018
    Configuration menu
    Copy the full SHA
    a1567ab View commit details
    Browse the repository at this point in the history