Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lambda): .net core 3.1 runtime #7105

Merged
merged 3 commits into from
Apr 2, 2020
Merged

feat(lambda): .net core 3.1 runtime #7105

merged 3 commits into from
Apr 2, 2020

Conversation

michaeldimoudis
Copy link
Contributor

Commit Message

Closes #7104

End Commit Message

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d22128c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

DerkSchooltink
DerkSchooltink suggested changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@DerkSchooltink DerkSchooltink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on master (to get these changes: #7024) and add in-code documentation instead of adding the linting exception :)

@michaeldimoudis michaeldimoudis force-pushed the 7104-netcore-31-lambda branch from d22128c to 2bbe206 Compare April 1, 2020 11:46
@michaeldimoudis
Copy link
Contributor Author

Please rebase on master (to get these changes: #7024) and add in-code documentation instead of adding the linting exception :)

No problem, this has been done now :)

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 2bbe206
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@michaeldimoudis
Copy link
Contributor Author

Hi @nija-at I saw you approved a similar PR, are you able to have a look at this PR please? Thank you.

@nija-at nija-at self-assigned this Apr 2, 2020
nija-at
nija-at previously requested changes Apr 2, 2020
View reviewed changes
packages/@aws-cdk/aws-lambda/lib/runtime.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed nija-at’s stale review April 2, 2020 09:35

Pull request has been modified.

@nija-at nija-at added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes labels Apr 2, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: be8c7c7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nija-at nija-at changed the title feat(lambda): .NET Core 3.1 runtime feat(lambda): .net core 3.1 runtime Apr 2, 2020
@mergify
Copy link
Contributor

mergify bot commented Apr 2, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: e174707
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 2, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ca2585c into aws:master Apr 2, 2020
@michaeldimoudis michaeldimoudis deleted the 7104-netcore-31-lambda branch April 4, 2020 10:47
@wmkDev
Copy link

wmkDev commented Apr 7, 2020

Hey guys, sorry if this is not the right place or if its a simple (or dumb) question, but how/when the package on "nuget / https://www.nuget.org/packages/Amazon.CDK.AWS.Lambda/" gets updated with the new runtime?

@nija-at
Copy link
Contributor

nija-at commented Apr 7, 2020

We have a weekly release cadence for the CDK. The new runtime will be available on our next release, later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerkSchooltink DerkSchooltink DerkSchooltink requested changes

@nija-at nija-at nija-at approved these changes

Assignees

@nija-at nija-at

Labels
pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support new .NET Core 3.1 Lambda runtime version
5 participants
@michaeldimoudis @aws-cdk-automation @wmkDev @nija-at @DerkSchooltink