Added info about passing values into a stack #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
reviewed
Sep 13, 2018
|
|
||
| .. code-block:: ts | ||
|
|
||
| // The class for the other stack |
There was a problem hiding this comment.
I'd like it better if you put the XferBucketProps along with this class here, and call it MyCdkStackProps. Two reasons:
- Naming: this is the convention.
- Order: You're referring to that interface here, but only defining it in a completely different block. That doesn't help scannability.
rix0rrr
approved these changes
Sep 13, 2018
eladb
approved these changes
Sep 17, 2018
docs/src/passing-in-data.rst
Outdated
| .. _passing_in_data: | ||
|
|
||
| ########################################## | ||
| Passing in External Data to Your |cdk| App |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.