Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aws-s3): remove bucket name validation #628

Merged
merged 2 commits into from
Sep 3, 2018
Merged

fix(aws-s3): remove bucket name validation #628

merged 2 commits into from
Sep 3, 2018

Commits on Aug 27, 2018

  1. fix(aws-s3): remove bucket name validation 

    Now that Tokens can be stringified, they can be inserted into parameters
like `bucketName`, which can lead to an input string like
`"bucket-name-${Token[TOKEN.0]}"`. We can't properly validate these
strings anymore.

Fixes #624.
    Rico Huijbers committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    8021faf View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2018

  1. Merge remote-tracking branch 'origin/master' into huijbers/bucket-nam… 

    …e-verification
    Rico Huijbers committed Sep 3, 2018
    Configuration menu
    Copy the full SHA
    f6d277b View commit details
    Browse the repository at this point in the history