Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(aws-ec2): SecurityGroup can be used in Connections #582

Merged
merged 3 commits into from
Aug 16, 2018

Commits on Aug 16, 2018

  1. BREAKING(aws-ec2): SecurityGroup can be used in Connections

    Refactoring of the object model for connection/security groups so that a
    SecurityGroup object can be used as the target of an .allowTo()
    statement:
    
        cluster.connections.allowTo(securityGroup)
    
    Also add SecurityGroupRef.import() to allow importing a non-constructed
    SecurityGroup into the construct tree.
    
    As part of the refactoring:
    
    - Get rid of IDefaultConnectable, the functionality has been folded into
      IConnectable/Connections.
    - Get rid of ISecurityGroup.
    - Rename IConnectionPeer => ISecurityGroupRule.
    - Drastically simplify implementation, get rid of recursion and classes
      to enable the recursion to terminate. All complex logic is now nicely
      contained within Connections.
    
    This change is BREAKING to connections-enabled construct writers, but
    transparent to application builders.
    
    Fixes #579.
    Rico Huijbers committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    69bd200 View commit details
    Browse the repository at this point in the history
  2. Update QuickStarts package to new API.

    - Don't forget to mention that SecurityGroupRef is now abstract
    and should be imported.
    Rico Huijbers committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    f47628a View commit details
    Browse the repository at this point in the history
  3. Small review fixes

    Rico Huijbers committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    240b8dc View commit details
    Browse the repository at this point in the history