fix(autoscaling): can't use MathExpression in scaleOnMetric
#5789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
requested review from
RomainMuller,
skinny85,
eladb,
iliapolo,
MrArnoldPalmer and
nija-at
It was not possible to use `MathExpression` objects in AutoScaling, because the `Alarm` interface has a bug: it takes "override" arguments like "period" and "statistic" that could and should have already been encoded into the `Metric` object passed to the alarm. Subsequently, AutoScaling used this ill-advised feature to force the period of metrics to 1 minute. This caused an invalid render for math expressions and was probably ill-advised to begin with. We should be respecting the customer's period on the metric they pass in. Fixes #5776. BREAKING CHANGE: AutoScaling by using `scaleOnMetric` will no longer force the alarm period to 1 minute, but use the period from the Metric object instead (5 minutes by default). Use `metric.with({ period: Duration.minute(1) })` to create a high-frequency scaling policy.
rix0rrr
force-pushed
the
huijbers/math-scaling
branch
from
d66a7b7 to
1408ead
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -672,7 +678,7 @@ function changeAllPeriods(metrics: Record<string, IMetric>, period: cdk.Duration | |||
| * both implementations of IMetric have a `period` member that contains that particular | |||
There was a problem hiding this comment.
Minor nit, is this doc paragraph still relevant?
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
MrArnoldPalmer
approved these changes
Jan 15, 2020
|
Thank you for contributing! Your pull request is now being automatically merged. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request is now being automatically merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Commit Message
fix(autoscaling): can't use
MathExpressioninscaleOnMetricIt was not possible to use
MathExpressionobjects in AutoScaling,because the
Alarminterface has a bug: it takes "override" argumentslike "period" and "statistic" that could and should have already been
encoded into the
Metricobject passed to the alarm.Subsequently, AutoScaling used this ill-advised feature to force the
period of metrics to 1 minute. This caused an invalid render for math
expressions and was probably ill-advised to begin with. We should be
respecting the customer's period on the metric they pass in.
Fixes #5776.
BREAKING CHANGE: AutoScaling by using
scaleOnMetricwill no longerforce the alarm period to 1 minute, but use the period from the Metric
object instead (5 minutes by default). Use
metric.with({ period: Duration.minute(1) })to create a high-frequency scaling policy.