Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(scripts): foreach.sh --up #5648

Merged
merged 2 commits into from
Jan 6, 2020
Merged

chore(scripts): foreach.sh --up #5648

merged 2 commits into from
Jan 6, 2020
+48 −15

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Jan 5, 2020

Add support for --up in foreach.sh which will execute the command for the current module and all its dependencies (instead of the entire repo).
Use this new feature in buildup so from now, buildup is resumable. Restart can be done through ./buildup --restart.

Update CONTRIBUTING guide.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

chore(build): foreach.sh --up
8e45957 
Add support for `--up` in `foreach.sh` which will execute the command for the current module and all its dependencies (instead of the entire repo).
Use this new feature in `buildup` so from now, `buildup` is resumable. Restart can be done through `./buildup --restart`.

Update CONTRIBUTING guide.
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 5, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nija-at nija-at added the pr/do-not-merge This PR should not be merged at this time. label Jan 5, 2020
nija-at
nija-at approved these changes Jan 5, 2020
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

I would prefix the commit title chore(scripts)

Noticed that rm -f "${statedir}/.foreach."* doesn't happen at the end of the script. I suppose an empty .foreach.state is also considered equivalent to this file being non-existent, yes?

@eladb eladb changed the title chore(build): foreach.sh --up chore(scripts): foreach.sh --up Jan 6, 2020
@eladb
Copy link
Contributor Author

eladb commented Jan 6, 2020

I suppose an empty .foreach.state is also considered equivalent to this file being non-existent, yes?

Actually, no. The script will simply tell the user that they need to --reset. But I recon we can automatically reset if foreach succeeds, good idea.

@eladb eladb merged commit 3b5959f into master Jan 6, 2020
@eladb eladb deleted the benisrae/foreach-buildup branch January 6, 2020 07:54
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nija-at nija-at nija-at approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. pr/do-not-merge This PR should not be merged at this time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eladb @aws-cdk-automation @nija-at