Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs) VPC: fromLookup() allows asymmetric vpc import #5563

Merged
merged 2 commits into from
Dec 27, 2019

Conversation

NetaNir
Copy link
Contributor

@NetaNir NetaNir commented Dec 27, 2019

Enabled in #4544 by @skinny85
Removed outdated section from aws-ec2


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@NetaNir NetaNir requested a review from rix0rrr December 27, 2019 08:30
@mergify
Copy link
Contributor

mergify bot commented Dec 27, 2019

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

rix0rrr
rix0rrr previously approved these changes Dec 27, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@NetaNir NetaNir force-pushed the neta/fix-docs-import-asymmetric-vpc branch from 2d40f9f to 97da0d8 Compare December 27, 2019 20:10
@mergify mergify bot dismissed rix0rrr’s stale review December 27, 2019 20:10

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Dec 27, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit c6b15ed into master Dec 27, 2019
@mergify mergify bot deleted the neta/fix-docs-import-asymmetric-vpc branch December 27, 2019 20:40
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants