Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(custom-resources): ignore DELETE after failed CREATE #5525

Merged
merged 5 commits into from
Dec 23, 2019
Merged

feat(custom-resources): ignore DELETE after failed CREATE #5525

merged 5 commits into from
Dec 23, 2019
+93 −29

Commits on Dec 23, 2019

  1. feat(custom-resources): ignore DELETE after failed CREATE 

    When a CREATE operation fails, CloudFormation will automatically issue a DELETE operation with the `PhysicalResourceId` submitted by the FAILED response. The provider framework currently does not support customizing the PhysicalResourceId of a failed response (as described in #5524), and therefore it makes more sense to have the framework simply ignore this DELETE operation. Otherwise, the user handler will need to special case this somehow, without proper signal.

The solution is to use a special marker for the physical resource ID when a CREATE fails, and recognize this marker in the subsequent DELETE.
    Elad Ben-Israel committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    b685f00 View commit details
    Browse the repository at this point in the history

  2. chore(build): resolve eslint plugins relative to cdk-build-tools 

    plugins are installed centrally under cdk-build-tools and therefore resolution should happen against that module instead of the current module. otherwise, we get an error `ESLint couldn't find the plugin "eslint-plugin-node".`
    Elad Ben-Israel committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    a43912e View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into benisrae/ignore-del… 

    …ete-after-failed-create
    Elad Ben-Israel committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    e46224f View commit details
    Browse the repository at this point in the history

  4. moved MISSING_MARKER to the last minute

    Elad Ben-Israel committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    abd7141 View commit details
    Browse the repository at this point in the history

  5. update expectations

    Elad Ben-Israel committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    1e37d4a View commit details
    Browse the repository at this point in the history