fix(codebuild): Rename codebuild vpc policy to a unique name #5385

eastNine · 2019-12-12T08:05:27Z

This fix prevents error when a stack has several codebuild projects.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

mergify · 2019-12-12T08:06:08Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

aws-cdk-automation · 2019-12-12T08:29:44Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

joehillen · 2019-12-13T22:38:46Z

packages/@aws-cdk/aws-codebuild/lib/project.ts

@@ -955,7 +955,7 @@ export class Project extends ProjectBase {
    }));

    const policy = new iam.Policy(this, 'PolicyDocument', {
-      policyName: 'CodeBuildEC2Policy',
+      policyName: this.node.uniqueId + ' CodeBuildEC2Policy',


Are you sure you want a space here?

It's okay if there's no space.

No. You misunderstood me. There is a space there that should not be. I'm don't think you can have spaces in policy names.

Yes,
I understood you mean that space is in policy name.
Should I modify it like this? :
this.node.uniqueId + 'CodeBuildEC2Policy'

aws-cdk-automation · 2019-12-14T05:16:17Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

It also modify expect test case.

aws-cdk-automation · 2019-12-14T06:10:41Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-14T06:30:09Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2019-12-16T12:32:48Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

mergify · 2019-12-16T13:00:36Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

mergify · 2019-12-16T13:52:56Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

mergify · 2019-12-16T14:38:36Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

mergify · 2019-12-16T14:51:53Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

mergify · 2019-12-16T15:17:00Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

aws-cdk-automation · 2019-12-17T02:26:02Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

skinny85

Thanks for the contribution @eastNine ! I have one suggestion.

skinny85 · 2019-12-17T18:03:46Z

packages/@aws-cdk/aws-codebuild/lib/project.ts

@@ -955,7 +955,7 @@ export class Project extends ProjectBase {
    }));

    const policy = new iam.Policy(this, 'PolicyDocument', {
-      policyName: 'CodeBuildEC2Policy',
+      policyName: this.node.uniqueId + 'CodeBuildEC2Policy',


Can you just remove policyName property from this line? This way, the CDK will use the generated ID of the Policy construct as the policyName.

Of course, your suggestion seems a better way!

aws-cdk-automation · 2019-12-18T02:49:14Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-18T03:13:08Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-12-18T03:52:46Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

skinny85

Thanks @eastNine !

mergify · 2019-12-18T16:54:24Z

Thank you for contributing! Your pull request is now being automatically merged.

aws-cdk-automation · 2019-12-18T17:27:41Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

fix(codebuild): Rename codebuild vpc policy

b78ad73

eastNine requested a review from skinny85 as a code owner December 12, 2019 08:05

SomayaB assigned skinny85 Dec 13, 2019

joehillen reviewed Dec 13, 2019

View reviewed changes

Merge branch 'master' into codebuild-fix

cc58235

eastNine added 2 commits December 14, 2019 14:57

remove a space in policy name

498e7aa

remove a space in policy name

a636407

It also modify expect test case.

Merge branch 'master' into codebuild-fix

5f8f058

skinny85 suggested changes Dec 17, 2019

View reviewed changes

remove codebuild vpc policy name

4ca6d84

fix expected test case

46af0f3

Merge branch 'master' into codebuild-fix

46ece1a

skinny85 approved these changes Dec 18, 2019

View reviewed changes

Merge branch 'master' into codebuild-fix

681e1a1

skinny85 merged commit 16a1200 into aws:master Dec 18, 2019

skinny85 mentioned this pull request Dec 20, 2019

Unable to create multiple CodeBuild stages in CodePipeline using CDK #5511

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(codebuild): Rename codebuild vpc policy to a unique name #5385

fix(codebuild): Rename codebuild vpc policy to a unique name #5385

eastNine commented Dec 12, 2019

mergify bot commented Dec 12, 2019

aws-cdk-automation commented Dec 12, 2019

joehillen Dec 13, 2019

eastNine Dec 14, 2019

joehillen Dec 14, 2019

eastNine Dec 14, 2019

joehillen Dec 14, 2019

aws-cdk-automation commented Dec 14, 2019

aws-cdk-automation commented Dec 14, 2019

aws-cdk-automation commented Dec 14, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

aws-cdk-automation commented Dec 17, 2019

skinny85 left a comment

skinny85 Dec 17, 2019

eastNine Dec 18, 2019

aws-cdk-automation commented Dec 18, 2019

aws-cdk-automation commented Dec 18, 2019

aws-cdk-automation commented Dec 18, 2019

skinny85 left a comment

mergify bot commented Dec 18, 2019

aws-cdk-automation commented Dec 18, 2019

fix(codebuild): Rename codebuild vpc policy to a unique name #5385

fix(codebuild): Rename codebuild vpc policy to a unique name #5385

Conversation

eastNine commented Dec 12, 2019

mergify bot commented Dec 12, 2019

aws-cdk-automation commented Dec 12, 2019

AWS CodeBuild CI Report

joehillen Dec 13, 2019

Choose a reason for hiding this comment

eastNine Dec 14, 2019

Choose a reason for hiding this comment

joehillen Dec 14, 2019

Choose a reason for hiding this comment

eastNine Dec 14, 2019

Choose a reason for hiding this comment

joehillen Dec 14, 2019

Choose a reason for hiding this comment

aws-cdk-automation commented Dec 14, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 14, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 14, 2019

AWS CodeBuild CI Report

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

aws-cdk-automation commented Dec 17, 2019

AWS CodeBuild CI Report

skinny85 left a comment

Choose a reason for hiding this comment

skinny85 Dec 17, 2019

Choose a reason for hiding this comment

eastNine Dec 18, 2019

Choose a reason for hiding this comment

aws-cdk-automation commented Dec 18, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 18, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Dec 18, 2019

AWS CodeBuild CI Report

skinny85 left a comment

Choose a reason for hiding this comment

mergify bot commented Dec 18, 2019

aws-cdk-automation commented Dec 18, 2019

AWS CodeBuild CI Report