[BREAKING] Move the CodeCommit and CodeBuild CodePipeline Actions #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
approved these changes
Jul 25, 2018
skinny85
changed the title
Thanks for the quick review!
Changed. |
This commit moves the CodeCommit PipelineSource and CodeBuild PipelineBuildAction from their respective service modules, and into their own dedicated aws-code*-codepipeline modules. This is needed, as placing the CodePipeline integrations in their respective Construct libraries was causing cyclical dependencies between the modules, and we want to keep the integrations experience uniform across the different services.
|
Corrected a typo in the ReadMe for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the CodeCommit PipelineSource and CodeBuild PipelineBuildAction from their respective service modules,
and into their own dedicated aws-code*-codepipeline modules.
This is needed, as placing the CodePipeline integrations in their respective Construct libraries
was causing cyclical dependencies between the modules,
and we want to keep the integrations experience uniform across the different services.
Related to changes in #401 .
By submitting this pull request, I confirm that my contribution is made under
the terms of the beta license.