Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove unsupported metadata target #3375

Merged
merged 1 commit into from
Jul 22, 2019

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented Jul 22, 2019

This was a leftover from a previous build that hadn't been cleaned up once
we realized our mistake and fixed it for the greater good... 🤷🏻‍♂️


Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@RomainMuller RomainMuller requested a review from a team as a code owner July 22, 2019 08:24
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t we need the metadata somewhere still?

@RomainMuller
Copy link
Contributor Author

RomainMuller commented Jul 22, 2019

@eladb - no. We're no longer using the "marketing name" of services for documentation page titles. Those are only enforced in the first line of the README.md files; but does not require a metadata entry.

@RomainMuller RomainMuller merged commit 5a6aff0 into master Jul 22, 2019
@RomainMuller RomainMuller deleted the rmuller/remove-metadata branch July 22, 2019 10:03
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants