Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecs): mark TaskDefinition inferenceAccelerators as deprecated #33248

Merged
merged 6 commits into from
Feb 3, 2025
Merged

fix(ecs): mark TaskDefinition inferenceAccelerators as deprecated #33248

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8dd1b60
Mark TaskDefinition inferenceAccelerators as deprecated
Jan 30, 2025
2adbb57
Merge branch 'main' into inferacc-depr
Leo10Gama Jan 31, 2025
8f5935a
Merge branch 'main' into inferacc-depr
Leo10Gama Feb 1, 2025
b5e510a
Merge branch 'main' into inferacc-depr
moelasmar Feb 3, 2025
45c2568
Merge branch 'main' into inferacc-depr
Leo10Gama Feb 3, 2025
ade05b5
Merge branch 'main' into inferacc-depr
mergify[bot] Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/aws-cdk-lib/aws-ecs/lib/base/task-definition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ export interface TaskDefinitionProps extends CommonTaskDefinitionProps {
* Not supported in Fargate.
*
* @default - No inference accelerators.
* @deprecated ECS TaskDefinition's inferenceAccelerator is EOL since April 2024
*/
readonly inferenceAccelerators?: InferenceAccelerator[];

Expand Down Expand Up @@ -721,6 +722,7 @@ export class TaskDefinition extends TaskDefinitionBase {

/**
* Adds an inference accelerator to the task definition.
* @deprecated ECS TaskDefinition's inferenceAccelerator is EOL since April 2024
*/
public addInferenceAccelerator(inferenceAccelerator: InferenceAccelerator) {
if (isFargateCompatible(this.compatibility)) {
Expand Down