chore(ec2-alpha): adding assertion for integration tests #33221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shikha372
force-pushed
the
vpcV2_assertions
branch
from
e51ef92 to
f0cc209
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33221 +/- ##
=======================================
Coverage 80.84% 80.84%
=======================================
Files 232 232
Lines 14135 14135
Branches 2460 2460
=======================================
Hits 11428 11428
Misses 2427 2427
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
shikha372
force-pushed
the
vpcV2_assertions
branch
from
f0cc209 to
746c5ae
Compare
shikha372
force-pushed
the
vpcV2_assertions
branch
from
746c5ae to
f4241e8
Compare
shikha372
force-pushed
the
vpcV2_assertions
branch
2 times, most recently
from
b78f84a to
7041843
Compare
shikha372
force-pushed
the
vpcV2_assertions
branch
from
7041843 to
211c2fa
Compare
shikha372
force-pushed
the
vpcV2_assertions
branch
from
211c2fa to
cac68f5
Compare
shikha372
force-pushed
the
vpcV2_assertions
branch
from
97fc724 to
a50036d
Compare
aws-cdk-automation
added
the
pr/needs-maintainer-review
samson-keung
requested changes
Jan 30, 2025
aws-cdk-automation
removed
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
samson-keung
approved these changes
Jan 31, 2025
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes N/A
Reason for this change
Added assertion for the integration tests that are related to security changes in the construct, needed for appsec approval.
Description of changes
Describe any new or updated permissions being added
No change in permissions
Description of how you validated changes
Deployed assertion changes in personal account.
yarn build
yarn test
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license