Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): hotswap deployments for CloudWatch Dashboards #33173

Closed
wants to merge 1 commit into from

Conversation

straygar
Copy link

Issue # (if applicable)

Closes #20051.

Reason for this change

CW Dashboard development can be made faster, similarly to StepFunctions State Machines.

Description of changes

The changes mirror the StepFunctions hotswap implementation, as the CFN resource and API calls are similar - update a JSON string that defines the resource.

Describe any new or updated permissions being added

n/a

Description of how you validated changes

Added and ran unit tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@straygar straygar requested a review from a team as a code owner January 27, 2025 09:04
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Jan 27, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 27, 2025 09:04
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jan 27, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.
❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/33173/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

✅ A exemption request has been requested. Please wait for a maintainer's review.

@straygar
Copy link
Author

Exemption Request: resource hotswapping changes do not require integration tests.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jan 27, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 555733f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@straygar
Copy link
Author

No clue why the codebuild is failing, I don't see anything related to my code in the logs.

@GavinZZ
Copy link
Contributor

GavinZZ commented Feb 18, 2025

@straygar thanks for the PR. Can you pull from latest main and resolve the conflicts? The CodeBuild CI issue is weird and perhaps pulling from main to re-trigger it will fix it.

Actually due to AWS CLI split, this package is now removed. Let's hold off and I will check with the CLI team to see what's the next step.

@GavinZZ GavinZZ added pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Feb 18, 2025
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

  • Resume work on the PR
  • OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
  • OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 7 days if no action is taken.

@kaizencc
Copy link
Contributor

@straygar bear with us while we move homes! the CDK cli is moving here: https://github.com/aws/aws-cdk-cli. It's a private package for now, but that link will be live later this week :).

we'll have more guidance on how we can migrate your PR over to that repository soon. in the meantime, can you let me know if you are still willing to contribute to the new repository? If so, i'll keep you in the loop as things progress.

@samson-keung samson-keung added the skip-abstractions-board signal to automated workflow to skip adding to project board label Feb 19, 2025
@straygar
Copy link
Author

@kaizencc For sure, no problem. @mrgrain let me know that I should stay put until march or so.

The changes here are very simple, so in the worst case I could just recreate them in the new repo when the repo split work is finalized.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Mar 6, 2025
Copy link

github-actions bot commented Mar 6, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 skip-abstractions-board signal to automated workflow to skip adding to project board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(CLI): hotswap support for CloudWatch Dashboards
5 participants