-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): hotswap deployments for CloudWatch Dashboards #33173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter fails with the following errors:
❌ Features must contain a change to an integration test file and the resulting snapshot.
❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/33173/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed, add Clarification Request
to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
Exemption Request: resource hotswapping changes do not require integration tests. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
No clue why the codebuild is failing, I don't see anything related to my code in the logs. |
@straygar thanks for the PR. Can you pull from latest main and resolve the conflicts? The CodeBuild CI issue is weird and perhaps pulling from main to re-trigger it will fix it. Actually due to AWS CLI split, this package is now removed. Let's hold off and I will check with the CLI team to see what's the next step. |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing To prevent automatic closure:
This PR will automatically close in 7 days if no action is taken. |
@straygar bear with us while we move homes! the CDK cli is moving here: https://github.com/aws/aws-cdk-cli. It's a private package for now, but that link will be live later this week :). we'll have more guidance on how we can migrate your PR over to that repository soon. in the meantime, can you let me know if you are still willing to contribute to the new repository? If so, i'll keep you in the loop as things progress. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #20051.
Reason for this change
CW Dashboard development can be made faster, similarly to StepFunctions State Machines.
Description of changes
The changes mirror the StepFunctions hotswap implementation, as the CFN resource and API calls are similar - update a JSON string that defines the resource.
Describe any new or updated permissions being added
n/a
Description of how you validated changes
Added and ran unit tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license