test(rds): refactor to notify user of all validation issues when initializing a new RDS DB Cluster #32841
Conversation
…ng a new RDS DB cluster
github-actions
bot
added
feature-request
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
| @@ -2093,30 +2172,6 @@ describe('cluster', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| test('throws if performanceInsightRetention is set but performance insights is disabled', () => { | |||
There was a problem hiding this comment.
These two tests did the same thing, removed them here and moved to line 567.
| }).toThrow('Aurora Limitless Database requires I/O optimized storage type, got: aurora'); | ||
| }); | ||
|
|
||
| test.each([[], undefined])('throw error for invalid cloudwatch log exports', (cloudwatchLogsExports) => { |
There was a problem hiding this comment.
Tested at line 584.
iankhou
changed the title
iankhou
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32841 +/- ##
=======================================
Coverage 81.52% 81.52%
=======================================
Files 222 222
Lines 13717 13717
Branches 2417 2417
=======================================
Hits 11183 11183
Misses 2254 2254
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
github-actions
bot
added
the
effort/small
aws-cdk-automation
added
the
pr/needs-maintainer-review
iankhou
changed the title
Issue #32840
Closes #32840
Reason for this change
When initializing a new RDS DB Cluster, the current implementation fails on the first validation error, making it possible for the user to encounter another failure after fixing known validation issues.
Description of changes
Implemented a validation function that collects all validation errors and presents them to the user.
Describe any new or updated permissions being added
No permissions changes.
Description of how you validated changes
Added unit tests and modified existing unit tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license