Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(msk): support ServerlessCluster #32780
feat(msk): support ServerlessCluster #32780
Changes from all commits
6147f11
f743a99
c9280c6
8816239
e8bf0bf
d955c5b
c4daabd
379ac23
bde2073
9c3ddcc
a18aff3
55a3ca1
bc20d7e
371314b
959ed05
cc8f2c8
f72c134
81a1ede
9f93036
c4db54e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This property is required and cannot be
false
.I tried deploying with
enabled
set tofalse
, but the deployment failed with the following error:As a result, I have decided not to expose this property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your information.
All the CloudFormation documents are useless, and I wish something could be done about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a TODO or some sort of comment here? My concern is that MSK team fix this issue and in the future if it supports IAM as disabled but something else as enabled, we know that this section of code needs to be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GavinZZ
Thank you. I have added a TODO comment.
Since MSK Serverless currently only supports IAM authentication, the inability to disable it seems to be the expected behavior.
https://docs.aws.amazon.com/msk/latest/developerguide/serverless.html
If additional authentication methods are supported in the future, it may become possible to disable it.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.