-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(appsync): correct schema definition for Query type #32638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request The code fails to deploy in its current state, preventing meaningful validation. Additionally, after reviewing the test files under the aws-appsync module, I couldn't find any tests specifically targeting Could you please consider exempting this change from mandatory test coverage, or guide me to any relevant test files if they do exist? |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #.
Reason for this change
The current schema is incorrect and it fails stack deployment. I got the following error:
AppStack | 14.47.29 | CREATE_FAILED | AWS::AppSync::Resolver | Api/QueryGetDemosConsistentResolver (ApiQueryGetDemosConsistentResolver47D5A89B) Resource handler returned message: "No field named getDemosConsistent found on type Query (Service: AppSync, Status Code: 404, Request ID: 49d05d60-ec48-484f-a5ea-ce4e07424291)" (RequestToken: 1776599b-8208-1445-0cfc-01cfb2bde3b1, HandlerErrorCode: NotFound) ❌ AppStack failed: Error: The stack named AppStack failed creation, it may need to be manually deleted from the AWS console: ROLLBACK_COMPLETE: Resource handler returned message: "No field named getDemosConsistent found on type Query (Service: AppSync, Status Code: 404, Request ID: 49d05d60-ec48-484f-a5ea-ce4e07424291)" (RequestToken: 1776599b-8208-1445-0cfc-01cfb2bde3b1, HandlerErrorCode: NotFound)
Description of changes
I had to change the
schema.graphql
as following to fix the bug and enable deployment:Describe any new or updated permissions being added
<!— What new or updated IAM permissions are needed to support the changes being introduced ? -->
Description of how you validated changes
I locally tested it. Basically, the new update enabled me to deploy the example stack.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license