feat(eks): Nodegroup support nodeRepairConfig
#32626
Conversation
github-actions
bot
added
repeat-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
phuhung273
changed the title
nodeRepairConfigNodegroup support nodeRepairConfig
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32626 +/- ##
=======================================
Coverage 82.35% 82.35%
=======================================
Files 120 120
Lines 6941 6941
Branches 1172 1172
=======================================
Hits 5716 5716
Misses 1120 1120
Partials 105 105
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
aws-cdk-automation
added
the
pr/needs-community-review
packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.nodegroup-repair-config.ts
Outdated
Show resolved
Hide resolved
| /** | ||
| * The node auto repair configuration for the node group. | ||
| * | ||
| * @see https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-eks-nodegroup-noderepairconfig.html |
There was a problem hiding this comment.
nit: I think this doc explains node repair config better
There was a problem hiding this comment.
Thanks, updated to use this doc
| @@ -1144,6 +1144,29 @@ describe('node group', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| test('create nodegroup correctly with enableNodeAutoRepair provided', () => { | |||
There was a problem hiding this comment.
can we add a test case to check for undefined value
There was a problem hiding this comment.
Thanks for taking a look. Can I ask for clarification that we want to add a testcase for:
new eks.Nodegroup(stack, 'Nodegroup', {
cluster,
enableNodeAutoRepair: undefined,
});
Why I want to ask is because other testcases don't have enableNodeAutoRepair specified, that means they already cover this undefined case. Also there are no changes in other integ snapshots.
Can you help suggest the situation where this might go wrong ?
There was a problem hiding this comment.
Thanks, since we mentioned that the default value will be false for this i assume this will be coming from CFN default since we are not explicitly setting default anywhere for this, was looking for that default case scenario.
aws-cdk-automation
removed
the
pr/needs-community-review
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #32562
Description of changes
nodeRepairConfigChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license