Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(spec2cdk): add tsdoc comment to describe the existance of a hardcoded list of resources in spec2cdk #32616

Merged
merged 3 commits into from
Dec 23, 2024

Merge branch 'main' into bobertzh/legacy-taggables

26e0fb9
Select commit
Loading
Failed to load commit list.
Merged

chore(spec2cdk): add tsdoc comment to describe the existance of a hardcoded list of resources in spec2cdk #32616

Merge branch 'main' into bobertzh/legacy-taggables
26e0fb9
Select commit
Loading
Failed to load commit list.
Mergify / Queue: Embarked in merge queue succeeded Dec 23, 2024 in 0s

The pull request embarked with main (ff21117) will be merged soon

Required conditions for merge:

  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #approved-reviews-by>=1
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0
  • -approved-reviews-by~=author
  • -closed
  • -label~=(blocked|do-not-merge|no-squash)
  • -merged
  • -title~=(WIP|wip)
  • base!=release
  • status-success=validate-pr
  • status-success~=AWS CodeBuild us-east-1
  • any of [🛡 GitHub branch protection]:
    • check-success = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
    • check-neutral = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
    • check-skipped = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
  • any of [🛡 GitHub branch protection]:
    • check-success = validate-pr
    • check-neutral = validate-pr
    • check-skipped = validate-pr
  • any of [🛡 GitHub branch protection]:
    • check-success = codecov/patch
    • check-neutral = codecov/patch
    • check-skipped = codecov/patch
  • any of [🛡 GitHub branch protection]:
    • check-success = codecov/patch/packages/aws-cdk
    • check-neutral = codecov/patch/packages/aws-cdk
    • check-skipped = codecov/patch/packages/aws-cdk
  • any of [🛡 GitHub branch protection]:
    • check-success = codecov/project
    • check-neutral = codecov/project
    • check-skipped = codecov/project
  • any of [🛡 GitHub branch protection]:
    • check-success = codecov/project/packages/aws-cdk
    • check-neutral = codecov/project/packages/aws-cdk
    • check-skipped = codecov/project/packages/aws-cdk

Check-runs and statuses of the embarked pull request #32616:

auto-approve details
submit-to-test-pipeline details
AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv) Build succeeded for project AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQvdetails
Analyze (javascript-typescript) details
Analyze (python) details
CodeQL — No new alerts in code changed by this pull requestdetails
cli-changes details
codecov/patch — Coverage not affected when comparing ff21117...26e0fb9details
codecov/patch/packages/aws-cdk — Coverage not affected when comparing ff21117...26e0fb9details
codecov/project — 80.54% (+0.00%) compared to ff21117details
codecov/project/packages/aws-cdk — 80.54% (+0.00%) compared to ff21117details
collect details
download-if-workflow-run details
validate-pr details