feat(cloudfront): distribution ARN property

[nmussy]

Issue # (if applicable)

Closes #32530

Reason for this change

Give the user access to a distribution's ARN via the existing distributionId value.

Description of changes

Implemented by proxying the existing formatDistributionArn function via a getter method.

Description of how you validated changes

Unit tests were added for both created and imported distributions.

Additionally, missing coverage for Distribution.fromDistributionAttributes was added, by copying the existing unit test for CloudFrontWebDistribution.fromDistributionAttributes.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[nmussy]

Exemption Request:

• A unit test should be sufficient, given there is no real added feature, just a getter method that uses an already relied upon function.
• The generated documentation should also be sufficient, adding an example on how to access a property would add needless noise

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.80%. Comparing base (d1bb1ca) to head (0833411).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #32531   +/-   ##
=======================================
  Coverage   78.80%   78.80%           
=======================================
  Files         108      108           
  Lines        7159     7159           
  Branches     1319     1319           
=======================================
  Hits         5642     5642           
  Misses       1332     1332           
  Partials      185      185           

Flag	Coverage Δ
suite.unit	78.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	78.80% <ø> (ø)

[tmokmss]

Nice, thanks! 😄

[tmokmss]

I found a typo in the PR title btw (cloudfornt)

[nmussy]

I found a typo in the PR title btw (cloudfornt)

Whoops, thanks. I thought the PR linter checked for existing packages?

EDIT: Must have confused it with this rule:

aws-cdk/tools/@aws-cdk/prlint/lint.ts

Lines 720 to 742 in bf026bd

	/**
	* Check that the PR title uses the typical convention for package names.
	*
	* For example, "fix(s3)" is preferred over "fix(aws-s3)".
	*/
	function validateTitleScope(pr: GitHubPr): TestResult {
	const result = new TestResult();
	const scopesExemptFromThisRule = ['aws-cdk-lib'];
	// Specific commit types are handled by `validateTitlePrefix`. This just checks whether
	// the scope includes an `aws-` prefix or not.
	// Group 1: Scope with parens - "(aws-<name>)"
	// Group 2: Scope name - "aws-<name>"
	// Group 3: Preferred scope name - "<name>"
	const titleRe = /^\w+(\((aws-([\w_-]+))\))?: /;
	const m = titleRe.exec(pr.title);
	if (m && !scopesExemptFromThisRule.includes(m[2])) {
	result.assessFailure(
	!!(m[2] && m[3]),
	`The title of the pull request should omit 'aws-' from the name of modified packages. Use '${m[3]}' instead of '${m[2]}'.`,
	);
	}
	return result;
	}

[godwingrs22]

LGTM. Thanks @nmussy for the contribution.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 0833411
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.