-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(msk-alpha): new KafkaVersions 3_7_X
and 3_7_X_KRAFT
#32515
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32515 +/- ##
=======================================
Coverage 79.13% 79.13%
=======================================
Files 107 107
Lines 7131 7131
Branches 1319 1319
=======================================
Hits 5643 5643
Misses 1304 1304
Partials 184 184
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR, I just noticed the lack of typing
3_7_X
and 3_7_X_KRAFT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
3_7_X
and 3_7_X_KRAFT
3_7_X
and 3_7_X_KRAFT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the addition and the helpful refactor :)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
None
Reason for this change
Update the CDK listed Kafka versions to match the current availability, as well as add missing deprecated versions
Description of changes
Even though there is a Metadata mode input in the web console (see announcement), there doesn't seem to be any associated fields, and the metadata mode is only dictated by the selected version according to the docs:
Given this, I don't see a reason to add a field to the
KafkaVersion
class to differentiate between the ZooKeeper and KRaft mode. This may easily be added in the future if needed.I've also refactored the tiered array to increase maintainability and align it with other version classes, such as the RDS
EngineVersion
s. See docs for supported versions:I don't think it's worth parsing the version to automatically determine the tiered storage support, as we already have non-semver versions and support may be dropped for future versions.
Description of how you validated changes
I compared the current CDK versions to live SDK data, using the
kafka:ListKafkaVersions
API results, and updated the cluster version integrationChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license