Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(msk-alpha): new KafkaVersions 3_7_X and 3_7_X_KRAFT #32515

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

nmussy
Copy link
Contributor

@nmussy nmussy commented Dec 13, 2024

Issue # (if applicable)

None

Reason for this change

Update the CDK listed Kafka versions to match the current availability, as well as add missing deprecated versions

Description of changes

Even though there is a Metadata mode input in the web console (see announcement), there doesn't seem to be any associated fields, and the metadata mode is only dictated by the selected version according to the docs:

To create a cluster in KRaft mode using the MSK API CreateCluster or CreateClusterV2 operations, you should use 3.7.x.kraft as the version. Use 3.7.x as the version to create a cluster in ZooKeeper mode.

Given this, I don't see a reason to add a field to the KafkaVersion class to differentiate between the ZooKeeper and KRaft mode. This may easily be added in the future if needed.

I've also refactored the tiered array to increase maintainability and align it with other version classes, such as the RDS EngineVersions. See docs for supported versions:

The Amazon MSK cluster with tiered storage enabled must use version 3.6.0 or higher, or 2.8.2.tiered.

I don't think it's worth parsing the version to automatically determine the tiered storage support, as we already have non-semver versions and support may be dropped for future versions.

Description of how you validated changes

I compared the current CDK versions to live SDK data, using the kafka:ListKafkaVersions API results, and updated the cluster version integration

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 13, 2024 16:27
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Dec 13, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@nmussy nmussy changed the title chore(msk-alpha): update KafkaVersion chore(msk-alpha): update KafkaVersion Dec 13, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 13, 2024 16:34

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.13%. Comparing base (dc1647e) to head (1aff2ee).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32515   +/-   ##
=======================================
  Coverage   79.13%   79.13%           
=======================================
  Files         107      107           
  Lines        7131     7131           
  Branches     1319     1319           
=======================================
  Hits         5643     5643           
  Misses       1304     1304           
  Partials      184      184           
Flag Coverage Δ
suite.unit 79.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.13% <ø> (ø)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, I just noticed the lack of typing

@nmussy nmussy marked this pull request as ready for review December 16, 2024 09:19
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 16, 2024
@kaizencc kaizencc changed the title chore(msk-alpha): update KafkaVersion feat(msk-alpha): KafkaVersions 3_7_X and 3_7_X_KRAFT Dec 19, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 19, 2024
@kaizencc kaizencc changed the title feat(msk-alpha): KafkaVersions 3_7_X and 3_7_X_KRAFT feat(msk-alpha): new KafkaVersions 3_7_X and 3_7_X_KRAFT Dec 19, 2024
@kaizencc kaizencc added the pr-linter/exempt-readme The PR linter will not require README changes label Dec 19, 2024
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the addition and the helpful refactor :)

@aws-cdk-automation aws-cdk-automation dismissed their stale review December 19, 2024 21:42

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1aff2ee
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Dec 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit cbacf4d into aws:main Dec 19, 2024
29 of 30 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants