chore(VpcV2): add default name tag for VPC and components #32360
Conversation
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32360 +/- ##
=======================================
Coverage 81.52% 81.52%
=======================================
Files 222 222
Lines 13715 13715
Branches 2417 2417
=======================================
Hits 11181 11181
Misses 2254 2254
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
shikha372
force-pushed
the
tagging_vpc
branch
from
eda7c60 to
74d925d
Compare
shikha372
changed the title
shikha372
force-pushed
the
tagging_vpc
branch
from
4f5dd98 to
b540262
Compare
shikha372
force-pushed
the
tagging_vpc
branch
from
b540262 to
6001172
Compare
shikha372
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Thanks @shikha372 ! Should we add a README section for this?
aws-cdk-automation
added
the
pr/needs-maintainer-review
| @@ -343,6 +345,11 @@ class IpamPool extends Resource implements IIpamPool { | |||
| throw new Error('awsService is required when addressFamily is set to ipv6'); | |||
| } | |||
|
|
|||
| //Add tags to the IPAM Pool if name is provided | |||
| if (props.ipamPoolName) { | |||
| Tags.of(this).add(NAME_TAG, props.ipamPoolName); | |||
There was a problem hiding this comment.
What if users want to add a custom tag that also called this name?
There was a problem hiding this comment.
This is added according to the resource name provided, even if they want to add NAME tag i wonder they would like it to rename it to some other value than the actual name of the resource.
aws-cdk-automation
removed
the
pr/needs-maintainer-review
Mainly done on the basis of what exists today in VPC class and other modules in EC2, if customers want to apply more tags they can do it with Tag Aspect. https://github.com/search?q=repo%3Aaws%2Faws-cdk%20NAME_TAG&type=code |
shikha372
changed the title
shikha372
force-pushed
the
tagging_vpc
branch
from
bf9c534 to
0f7f0ff
Compare
shikha372
force-pushed
the
tagging_vpc
branch
from
0f7f0ff to
7ce35b2
Compare
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes RFC#507.
Tracking (#30762 )
Reason for this change
Added Name tag for VPC and related components.
Description of changes
Tag fields not supported in CFN schema for Route and Egress-only-IGW.
Description of how you validated changes
Added unit test and integration tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license